Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#45896] Generate PDF document from a work package description #15850

Merged
merged 73 commits into from
Nov 20, 2024
Merged

[#45896] Generate PDF document from a work package description #15850

merged 73 commits into from
Nov 20, 2024

Conversation

as-op
Copy link
Contributor

@as-op as-op commented Jun 13, 2024 •
edited
Loading

  • Refactor for better resue
  • Reuse logo handling from PDF report
  • Use md-to-pdf to generate the document from a work package description
  • Trigger with entry in work package drop down menu
  • Hide behind feature flag generate_pdf_from_work_package
  • Dialog
    • turbo/primer dialog
    • use dialog parameters
  • Specs

https://community.openproject.org/work_packages/45896

as-op added 2 commits August 26, 2024 16:26
@as-op
Merge branch 'refs/heads/dev' into feature/45896-generate-pdf-documen…
92d5ebc 
…t-from-a-work-package-description

# Conflicts:
#	frontend/src/vendor/ckeditor/ckeditor.js
#	frontend/src/vendor/ckeditor/ckeditor.js.map
@as-op
use ckeditor with page break support
483ec8f
@as-op as-op marked this pull request as ready for review November 19, 2024 15:51
@EinLama EinLama self-requested a review November 20, 2024 09:04
EinLama
EinLama requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@EinLama EinLama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of questions and smaller notes.

I tried generating some PDFs and it works and looks great! Great job :) Couldn't see any performance issues due to creating it synchronously, but didn't try it with a giant work package.

app/components/work_packages/exports/generate/modal_dialog_component.rb Show resolved Hide resolved
app/components/work_packages/exports/generate/modal_dialog_component.rb Show resolved Hide resolved
app/models/work_package/pdf_export/common/attachments.rb Outdated Show resolved Hide resolved
app/models/work_package/pdf_export/common/logo.rb Outdated Show resolved Hide resolved
app/models/work_package/pdf_export/common/logo.rb Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
app/models/work_package/pdf_export/generator/contracts.yml Show resolved Hide resolved
spec/models/work_package/pdf_export/document_generator_spec.rb Show resolved Hide resolved
spec/models/work_package/pdf_export/document_generator_spec.rb Show resolved Hide resolved
app/models/work_package/pdf_export/common/common.rb Show resolved Hide resolved
as-op and others added 10 commits November 20, 2024 12:02
@as-op
lint(codestyle): add empty line, remove sorting
16e9e86 
closes #15850 (comment)
@as-op
lint(codestyle): better alias usage
1543be9 
closes #15850 (comment)
@as-op
lint(codestyle): shorter code
6317f82 
closes #15850 (comment)
@as-op
lint(legal): add copyright notice to every file; add frozen_string_li…
999dd53 
…teral

closes #15850 (comment)
@as-op
fix(assets): remove OpenSans font
067d0f5 
closes #15850 (comment)
@as-op
fix(specs): add description to commented out PDF preview in specs
f644789 
closes #15850 (comment)
@as-op
Merge remote-tracking branch 'origin/feature/45896-generate-pdf-docum…
aab65f5 
…ent-from-a-work-package-description' into feature/45896-generate-pdf-document-from-a-work-package-description
@as-op
Merge branch 'dev' into feature/45896-generate-pdf-document-from-a-wo…
d8bbf5e 
…rk-package-description
@as-op
fix(endpoint): use POST for form submit endpoint
f844718 
closes #15850 (comment)
@as-op
Merge remote-tracking branch 'origin/feature/45896-generate-pdf-docum…
003f874 
…ent-from-a-work-package-description' into feature/45896-generate-pdf-document-from-a-work-package-description
EinLama
EinLama approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@EinLama EinLama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉

@as-op as-op merged commit 2fbaf7d into dev Nov 20, 2024
13 of 14 checks passed
@as-op as-op deleted the feature/45896-generate-pdf-document-from-a-work-package-description branch November 20, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EinLama EinLama EinLama approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@as-op @lindenthal @EinLama